Some memory backport 8.2#12086
Merged
ton31337 merged 3 commits intoFRRouting:stable/8.2from Oct 11, 2022
Merged
Conversation
…te into stack Even though OSPF_MAX_LSA_SIZE is quite large and holds the upper bound on what can be written into a lsa, let's add a small check to ensure it is not possible to do a bad thing. This wins one of the long standing bug awards. 2003! Fixes: FRRouting#11602 Signed-off-by: Donald Sharp <[email protected]>
unpack_tlv_router_cap allocates memory that in the error case is not being freed. Signed-off-by: Donald Sharp <[email protected]>
Ensure that if the capability length specified is enough data. Signed-off-by: Donald Sharp <[email protected]>
ton31337
approved these changes
Oct 10, 2022
Collaborator
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests Ubuntu 18.04 amd64 part 6: Incomplete(check logs for details)Successful on other platforms/tests
|
Member
|
ci:rerun Ubuntu 18.04 amd64 Part 6 did not complete |
Collaborator
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7818/ This is a comment from an automated CI system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #11656 fixing up the %pBP thingie.